Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🤖 Sync from open-cluster-management-io/config-policy-controller: #163 #580

Merged
merged 2 commits into from
Sep 20, 2023
Merged

🤖 Sync from open-cluster-management-io/config-policy-controller: #163 #580

merged 2 commits into from
Sep 20, 2023

Conversation

magic-mirror-bot[bot]
Copy link

@JustinKuli
Add an error when the apiVersion is missing
5a67c4a 
The apiVersion field is generally required by kubernetes objects... it's
surprising that this situation wasn't already caught by an error when
decoding or getting a mapping.

Refs:
 - https://issues.redhat.com/browse/ACM-7127

Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
(cherry picked from commit f997dbc)
@JustinKuli
Add debug to enforce with status test
ecb7a19 
This test has been flakey - the last check for Compliant events has been
coming back empty unexpectedly. This will print information about all of
the events to help understand what is happening.

Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
(cherry picked from commit 62a3ac4)
@openshift-ci
Copy link

openshift-ci bot commented Sep 20, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: magic-mirror-bot[bot]
Once this PR has been reviewed and has the lgtm label, please assign dhaiducek for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sonarcloud
Copy link

sonarcloud bot commented Sep 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@magic-mirror-bot magic-mirror-bot bot merged commit 9dc339c into main Sep 20, 2023
11 checks passed
@magic-mirror-bot magic-mirror-bot bot deleted the magic-mirror-main-1695240723501 branch September 20, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dco-signoff: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JustinKuli